Bugfix: Filter out parameter that do not match target encoder #1333
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This deals with the problem that arises when format-unspecific encoders are provided with parameters that are not present in the final target encoder.
For example, the following call can take place with the
quality
argument.If the source image and thus the target encoder supports
quality
(e.g. Jpeg), everything works fine. However, if the input format does not containquality
in the target encoder (e.g. PNG), an error occurs.The logic has only been adapted since version 3.6, so this does not affect previous versions.
See #1332